Changeset 27

Timestamp:

05/31/09 11:31:09 (3 years ago)

Author:

fumanchu

Message:

Fixed leading whitespace issues in test.statement.

Location:

trunk/epic

Files:

• epic.sql (modified) (4 diffs)
• test/test_core.sql (added)

trunk/epic/epic.sql

@@ -212 +212 @@
 
 CREATE OR REPLACE FUNCTION test.statement(call text) RETURNS text AS $$
+-- Returns the given SQL string, prepending "SELECT * FROM " if missing.
 DECLARE
   result    text;
 BEGIN
   result := rtrim(call, ';');
-  IF NOT result ILIKE 'SELECT%' THEN
+  IF NOT result ~* '^[[:space:]]*SELECT[[:space:]]' THEN
     result := 'SELECT * FROM ' || result;
   END IF;
@@ -228 +229 @@
 
 CREATE OR REPLACE FUNCTION test._ensure_globals() RETURNS boolean AS $$
+-- Creates the global id sequence if it does not already exist.
 BEGIN
   SET client_min_messages = warning;
@@ -703 +705 @@
 -- 
 --    PERFORM test.assert_rows('SELECT first, last, city FROM table1',
---                             'SELECT ''Davy'', ''Crockett'', NULL';
+--                             'SELECT ''Davy'', ''Crockett'', NULL');
 DECLARE
   rec     record;
@@ -752 +754 @@
   -- Dump the call output into a temp table
   IF colname IS NULL THEN
+    -- No colname; instead, create the temp table and then read the catalog
+    -- to grab the name of the first column.
     EXECUTE 'CREATE TEMPORARY TABLE _test_assert_column_base AS ' || test.statement(call);
     SELECT INTO firstname a.attname